Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-1060:Implement Welsh translated Accessibility Statement 260321 #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Deep547
Copy link
Contributor

@Deep547 Deep547 commented Apr 16, 2021

PAS-1060

Implement Welsh translated Accessibility Statement 260321

Implement Welsh translated Accessibility Statement 260321

PR Suggestions

  • Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?
  • Have you done a visual check of the changes?
  • Is there any still commented or unused code? Lingering printlns?
  • Have things been implemented in a complicated way?
  • Are the test still over the coverage threshold?
  • Does the compiler throw a lot of warnings?
  • Have methods and tests been named clearly?
  • Were there any changes in the config? Do changes need to be made in app-config-???

Checklist PR Raiser

  • I've made every effort to commit high quality, clean code and I have executed relevant static analyses to be sure
  • I've included appropriate tests with any code I've added (Unit, Integration, Acceptance etc.)
  • I've executed the acceptance test pack locally to ensure there are no functional regressions (Performance tests where relevant)
  • I've squashed my commits - including the JIRA issue number in the commit message
  • I've run a dependency check to ensure all dependencies are up to date
  • I've added the links for relevant PRs for AT/PT in description

Checklist PR Reviewer

  • I've made every effort to commit high quality, clean code and I have executed relevant static analyses to be sure
  • I've included appropriate tests with any code I've added (Unit, Integration, Acceptance etc.)
  • I've executed the acceptance test pack locally to ensure there are no functional regressions (Performance tests where relevant)
  • I've squashed my commits - including the JIRA issue number in the commit message
  • I've run a dependency check to ensure all dependencies are up to date
  • I've verified the links for relevant PRs for AT/PT in description before approval

@matthewmascord
Copy link
Contributor

retest this please

@hmrc-web-operations hmrc-web-operations changed the base branch from master to main October 21, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants